Review Request: Fix directory navigation in Dolphin::Terminal.

Raphael Kubo da Costa kubito at gmail.com
Tue Apr 12 05:37:55 BST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101096/
-----------------------------------------------------------

Review request for KDE Base Apps.


Summary
-------

Fix directory navigation in Dolphin::Terminal.

When navigating in Dolphin it attempts to keep any open Terminal (F4)
in sync by changing the directory in the shell.  It does this by
sending a "^C; cd $DIRECTORY" however shells under FreeBSD treat "^C"
as a literal string and not SIGINT.  Fix this by sending SIGINT to the
shell instead of "^C".

It appears Linux does not exhibit this behaviour.

Patch originally written by David Naylor, from the KDE-FreeBSD team.


Diffs
-----

  dolphin/src/panels/terminal/terminalpanel.cpp 61d80cbfa26fb17d0ba403a52f2ab57fbae7b3cc 

Diff: http://git.reviewboard.kde.org/r/101096/diff


Testing
-------

Changing directories with a terminal open now changes the terminal's current directory fine on FreeBSD.


Thanks,

Raphael

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20110412/abe6e07b/attachment.htm>


More information about the kde-core-devel mailing list