Review Request: create a menu entry in the help menu to enable all the "do not ask again"

Christoph Feck christoph at maxiom.de
Wed Sep 29 15:39:47 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5469/#review7876
-----------------------------------------------------------


Good idea. Please add a message box informing the user what the effect the invocation was. Right now, if you select that action, nothing (visually) happens.

And yes, this message box should probably have the "do not ask again" checkbox, so that the point is clear :)

I will check later if there are other places where the new enum needs to added, I remember reading some comments that those enums need to be in sync in multiple places.

- Christoph


On 2010-09-29 13:37:08, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5469/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 13:37:08)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Create a menu entry in the help menu to enable again all the "do not ask again" messagebox for that application.
> Probably there is a better description for the menu entry (but I can not find it).
> Also, the icon for the entry is missing (or does it need an icon?)
> 
> I hope this is Binary Compatible.
> 
> Of course, when I'll commit, I'll remove all the trailing spaces (How can I see them before doing a post-review?).
> 
> 
> This addresses bug 190238.
>     https://bugs.kde.org/show_bug.cgi?id=190238
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp 1180729 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction_p.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp 1180729 
>   /trunk/KDE/kdelibs/kdeui/xmlgui/ui_standards.rc 1180729 
> 
> Diff: http://svn.reviewboard.kde.org/r/5469/diff
> 
> 
> Testing
> -------
> 
> konsole ask again "Do you have multiplies tabs, do you want to close,....."
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100929/b9fc3bfc/attachment.htm>


More information about the kde-core-devel mailing list