<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5469/">http://svn.reviewboard.kde.org/r/5469/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Good idea. Please add a message box informing the user what the effect the invocation was. Right now, if you select that action, nothing (visually) happens.
And yes, this message box should probably have the "do not ask again" checkbox, so that the point is clear :)
I will check later if there are other places where the new enum needs to added, I remember reading some comments that those enums need to be in sync in multiple places.</pre>
<br />
<p>- Christoph</p>
<br />
<p>On September 29th, 2010, 1:37 p.m., Jaime Torres wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-09-29 13:37:08</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create a menu entry in the help menu to enable again all the "do not ask again" messagebox for that application.
Probably there is a better description for the menu entry (but I can not find it).
Also, the icon for the entry is missing (or does it need an icon?)
I hope this is Binary Compatible.
Of course, when I'll commit, I'll remove all the trailing spaces (How can I see them before doing a post-review?).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">konsole ask again "Do you have multiplies tabs, do you want to close,....."
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=190238">190238</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction_p.h <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/xmlgui/ui_standards.rc <span style="color: grey">(1180729)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5469/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>