Review Request: create a menu entry in the help menu to enable all the "do not ask again"

[David Jarvie]

> On 2010-09-29 11:37:25, David Jarvie wrote:
> > /trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp, line 207
> > <http://svn.reviewboard.kde.org/r/5469/diff/2/?file=38660#file38660line207>
> >
> >     Is it possible to use the same keyboard accelerator here as in kstandardaction_p.h? That will avoid the translators having to deal with two separate strings.
> 
> Jaime Torres wrote:
>     If this is possible (using a common _p.h file?) all the menu entries in khelpmenu.cpp should be converted.

If the same string is in two different files, it only has to be translated once. But in your patch, the new strings are different in the two files, because in one the keyboard accelerator is "A", while in the other it is "N", so this results in TWO strings to translate. If you could use the same accelerator, this would reduce the number of new strings to translate from two to one.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5469/#review7872
-----------------------------------------------------------


On 2010-09-29 11:32:14, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5469/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 11:32:14)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Create a menu entry in the help menu to enable again all the "do not ask again" messagebox for that application.
> Probably there is a better description for the menu entry (but I can not find it).
> Also, the icon for the entry is missing (or does it need an icon?)
> 
> I hope this is Binary Compatible.
> 
> Of course, when I'll commit, I'll remove all the trailing spaces (How can I see them before doing a post-review?).
> 
> 
> This addresses bug 190238.
>     https://bugs.kde.org/show_bug.cgi?id=190238
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/xmlgui/ui_standards.rc 1180729 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp 1180729 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction_p.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp 1180729 
> 
> Diff: http://svn.reviewboard.kde.org/r/5469/diff
> 
> 
> Testing
> -------
> 
> konsole ask again "Do you have multiplies tabs, do you want to close,....."
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100929/bd9bba56/attachment.htm>