<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5469/">http://svn.reviewboard.kde.org/r/5469/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 29th, 2010, 11:37 a.m., <b>David Jarvie</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5469/diff/2/?file=38660#file38660line207" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KMenu* KHelpMenu::menu()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">198</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">d</span><span class="o">-></span><span class="n">mEnableAllMessagesAction</span> <span class="o">=</span> <span class="n">d</span><span class="o">-></span><span class="n">mMenu</span><span class="o">-></span><span class="n">addAction</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Re-enable </span><span class="se">\"</span><span class="s">Do &Not Ask Again</span><span class="se">\"</span><span class="s"> Messages"</span> <span class="p">),</span> <span class="k">this</span><span class="p">,</span> <span class="n">SLOT</span><span class="p">(</span><span class="n">enableAllMessages</span><span class="p">())</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it possible to use the same keyboard accelerator here as in kstandardaction_p.h? That will avoid the translators having to deal with two separate strings.</pre>
</blockquote>
<p>On September 29th, 2010, 11:41 a.m., <b>Jaime Torres</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If this is possible (using a common _p.h file?) all the menu entries in khelpmenu.cpp should be converted.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the same string is in two different files, it only has to be translated once. But in your patch, the new strings are different in the two files, because in one the keyboard accelerator is "A", while in the other it is "N", so this results in TWO strings to translate. If you could use the same accelerator, this would reduce the number of new strings to translate from two to one.</pre>
<br />
<p>- David</p>
<br />
<p>On September 29th, 2010, 11:32 a.m., Jaime Torres wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Jaime Torres.</div>
<p style="color: grey;"><i>Updated 2010-09-29 11:32:14</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Create a menu entry in the help menu to enable again all the "do not ask again" messagebox for that application.
Probably there is a better description for the menu entry (but I can not find it).
Also, the icon for the entry is missing (or does it need an icon?)
I hope this is Binary Compatible.
Of course, when I'll commit, I'll remove all the trailing spaces (How can I see them before doing a post-review?).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">konsole ask again "Do you have multiplies tabs, do you want to close,....."
</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=190238">190238</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kdeui/xmlgui/ui_standards.rc <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/actions/kstandardaction_p.h <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h <span style="color: grey">(1180729)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp <span style="color: grey">(1180729)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5469/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>