Review Request: Attica will not be found if installed under /usr/local/

[Alexander Neundorf]

On Tuesday 28 September 2010, Guy Maurel wrote:
> On Sunday 26 September 2010 14:19:00 Alexander Neundorf wrote:
> > On Sunday 26 September 2010, Alexander Neundorf wrote:
> > > On Thursday 23 September 2010, Alexander Neundorf wrote:
> > > > On Thursday 23 September 2010, Guy Maurel wrote:
> > > > > On Wednesday 22 September 2010 21:28:35 you wrote:
> > >
> > > ...
> > >
> > > > > > We have FindPackageHandleStandardArgs.cmake in kdelibs from
> > > > > > current cmake, please have a look at its documentation.
> > > > > > It should be possible to remove the whole version checking chunk
> > > > > > and just do
> > > > >
> > > > > This really the *better* way.
> > > > > Could it be possible to move (all) the cmake files to this method?
> > > > > It will be an improvment for all of us!
> > > >
> > > > Of course, it just needs somebody to do it :-)
> > > >
> > > > I'd be very happy if you help with this and start posting patches for
> > > > review to kde-buildsystem (it is important not to break source
> > > > compatiblity).
> > >
> > > Done for kdelibs/cmake/modules/FindSharedMimeInfo.cmake.
> > > All results (i.e. the executable and the version string are also cached
> > > properly, no need for the if(...FOUND) donothing ELSE() hacks.
> > >
> > > You can now also do
> > > find_package(SharedMimeInfo <version>.<you>.<need>)
> > >
> > >
> > > Looking forward to patches for other Find-modules :-)
> >
> > Ok, now also done for:
> > * FindLibAttica.cmake
> > * FindFlex.cmake
> > * FindLCMS.cmake
> > * FindOggVorbis.cmake
> > * FindPolkitQt-1.cmake
> > * FindPolkitQt.cmake
> >
> > There are still enough modules left, patches welcome :-)
> >
> > Alex
>
> The new version of FindLibAttica.cmake is fine but...
> It doesn't give me what I wished.

The find-module will continue to prefer the output from pkg-config (or you 
convince our developers that the output from pkg-config should be used as 
last option, not as first option).

Alex