Knights moved to kdereview

[Anne-Marie Mahfouf]

Hi,

I reproduce on trunk (KGR enabled).
It only happens on default settings (with no Settings::Theme() in the .rc 
file).  Changing theme before loading a game works and then default theme also 
works when changed back. It's first run that crashes.

The .desktop file is not found at first run by
    QString filePath = KStandardDirs::locate("appdata", fileName);
in kgametheme.cpp
as fileName is "default" while it should be "themes/default.desktop".

When I go to Settings->Configure Knights and change the theme then the corrct 
filename is then set.

The culprit seems 
renderer = new Renderer( Settings::theme() );
and then you call 
renderer->setTheme( Settings::theme() );
in board.cpp 

From there I did not go further but maybe Stefan can help you.

Best regards and good debugging,

Anne-Marie

On Monday 27 September 2010 22:18:10 Miha Čančula wrote:
> > >Also knights fails to start here, can't find themes and crashes after
> > >lots
> > 
> > of
> > 
> > >knights(6193)/libkdegames KGameRendererPrivate::setTheme: Theme change
> > 
> > failed:
> > >Desktop file broken
> > >knights(6193)/libkdegames KGameTheme::load: Refusing to load theme with
> > >no name
> > 
> > >knights(6193)/libkdegames KGameRenderer::setTheme: Setting theme:
> > "default"
> > 
> > >knights(6193)/libkdegames KGameTheme::load: Attempting to load .desktop
> > >at
> > 
> > ""
> > I will look into it.
> > 
> > >Other KGameTheme based games like kmines work.
> 
> I can't reproduce it, with either trunk (KGR enabled) or 4.5.1 stable.
> What's your setup?