Review Request: Cleanup KLed

Christoph Feck christoph at
Fri Sep 17 05:40:20 BST 2010

This is an automatically generated e-mail. To reply, visit:

(Updated 2010-09-17 04:40:17.362143)

Review request for kdelibs.


* try a raised frame for Raised look
* try to "glow" the dark border color when LED is On
* fix alignment inside margins
* fix cache not updated on resize
* use 0° degree light angle (same as Oxygen and many other styles)
* make border width relative to size


* massive code reduction by using Qt gradients
* fix background, now uses transparency
* fix cache not updated on look changes
* fix cropped appearance
* simplify cachedPixmap handling
* use SmallIconSize as sizeHint
* remove "builtin" benchmark

I would like to get feedback on the changed rendering of rectangular LEDs.

This addresses bug 98719.

Diffs (updated)

  /trunk/KDE/kdelibs/kdeui/widgets/kled.h 1176221 
  /trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1176221 




OLD appearance
NEW appearance
V2 appearance



-------------- next part --------------
An HTML attachment was scrubbed...
URL: <>

More information about the kde-core-devel mailing list