Review Request: Cleanup KLed

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5369/
-----------------------------------------------------------

(Updated 2010-09-17 04:40:17.362143)


Review request for kdelibs.


Changes
-------

* try a raised frame for Raised look
* try to "glow" the dark border color when LED is On
* fix alignment inside margins
* fix cache not updated on resize
* use 0° degree light angle (same as Oxygen and many other styles)
* make border width relative to size


Summary
-------

* massive code reduction by using Qt gradients
* fix background, now uses transparency
* fix cache not updated on look changes
* fix cropped appearance
* simplify cachedPixmap handling
* use SmallIconSize as sizeHint
* remove "builtin" benchmark

I would like to get feedback on the changed rendering of rectangular LEDs.


This addresses bug 98719.
    https://bugs.kde.org/show_bug.cgi?id=98719


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/widgets/kled.h 1176221 
  /trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1176221 

Diff: http://svn.reviewboard.kde.org/r/5369/diff


Testing
-------


Screenshots
-----------

OLD appearance
  http://svn.reviewboard.kde.org/r/5369/s/505/
NEW appearance
  http://svn.reviewboard.kde.org/r/5369/s/506/
V2 appearance
  http://svn.reviewboard.kde.org/r/5369/s/507/


Thanks,

Christoph

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100917/3c34e21e/attachment.htm>