Review Request: Cleanup KLed

[Todd]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5369/#review7647
-----------------------------------------------------------


Mostly it looks good, a lot better than it was, but I have a some suggestions:

* The black on and off states are identical as far as I can see
* The edges of the "raised" version do not look very raised.  I would either get rid of it or give it a gradient like in the sunken version.
* If possible, I would not have the gradient at 45 degrees like it is now, I would have it a bit closer to horizontal or vertical.  Having it at an angle that is +/-45 degrees looks artificial to me,the chance of a light source really being at that angle is slim.  I also don't like having the light of the gradient in the sunken version right on the corner, which this would fix.
* I would make the white just a little off-white.  Once again it looks too perfect, which looks artificial to me.
* If possible, it would be nice if the borders had a slight tint from the LED color when in the on state (but not the off state), to make it look like light from the LED is falling on the border.
* I would make the blue on state a lighter shade, it is not bright enough in my opinion. I would also make the off state a bit brighter, so it is easier to tell apart from black's off state.
* I would make the edges a bit thicker in the large versions, at least for the sunken and raised versions.  They seem too small relative to the size of the button to me.

- Todd


On 2010-09-17 02:04:09, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5369/
> -----------------------------------------------------------
> 
> (Updated 2010-09-17 02:04:09)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> * massive code reduction by using Qt gradients
> * fix background, now uses transparency
> * fix cache not updated on look changes
> * fix cropped appearance
> * simplify cachedPixmap handling
> * use SmallIconSize as sizeHint
> * remove "builtin" benchmark
> 
> I would like to get feedback on the changed rendering of rectangular LEDs.
> 
> 
> This addresses bug 98719.
>     https://bugs.kde.org/show_bug.cgi?id=98719
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/kled.h 1176162 
>   /trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1176162 
> 
> Diff: http://svn.reviewboard.kde.org/r/5369/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> OLD appearance
>   http://svn.reviewboard.kde.org/r/5369/s/505/
> NEW appearance
>   http://svn.reviewboard.kde.org/r/5369/s/506/
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100917/8bfa5164/attachment.htm>