Review Request: Cleanup KLed
Christoph Feck
christoph at maxiom.de
Fri Sep 17 03:04:10 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5369/
-----------------------------------------------------------
Review request for kdelibs.
Summary
-------
* massive code reduction by using Qt gradients
* fix background, now uses transparency
* fix cache not updated on look changes
* fix cropped appearance
* simplify cachedPixmap handling
* use SmallIconSize as sizeHint
* remove "builtin" benchmark
I would like to get feedback on the changed rendering of rectangular LEDs.
This addresses bug 98719.
https://bugs.kde.org/show_bug.cgi?id=98719
Diffs
-----
/trunk/KDE/kdelibs/kdeui/widgets/kled.h 1176162
/trunk/KDE/kdelibs/kdeui/widgets/kled.cpp 1176162
Diff: http://svn.reviewboard.kde.org/r/5369/diff
Testing
-------
Screenshots
-----------
OLD appearance
http://svn.reviewboard.kde.org/r/5369/s/505/
NEW appearance
http://svn.reviewboard.kde.org/r/5369/s/506/
Thanks,
Christoph
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100917/9025dd10/attachment.htm>
More information about the kde-core-devel
mailing list