Review Request: the soprano-depency for kdelibs ist not correct

[Guy Maurel]

> On 2010-09-15 13:15:29, Sebastian Trueg wrote:
> > Why does kdelibs need Soprano 2.5.63. It might very well be that I missed something but where is the new functionality needed?
> 
> Guy Maurel wrote:
>     OK, it is not exact enought!
>     types/entity.cpp:        else if ( property == Soprano::Vocabulary::NAO::userVisible() ) {
>     
>     entity.cpp needs userVisible from soprano/nao.h
> 
> Guy Maurel wrote:
>     It seems to be more complicated as I thought.
>     I have a soprano-version: 2.5.2. Too less!
>     But the CMake doesn't complain.
>     If I comment out the lines around
>     set(SOPRANO_MIN_VERSION "1.99") 
>     in the file cmake/modules/FindSoprano.cmake
>     I get the wished information about the OPTIONAL package ... Soprano (2.5.60 or higher)
> 
> Sebastian Trueg wrote:
>     Is this a clean build?

No! It is my error.
BUT.
I made now a clean build. Here some more details to show the problem:
I have a file /usr/local/include/soprano/version.h
with: #define SOPRANO_VERSION_STRING "2.4.61"

The cmake-command gives (only the relevant lines are shown here):
-- Soprano version 2.4.61 is too old. Please install 2.5.60 or newer
-- Found Soprano: /usr/local/include
...
-----------------------------------------------------------------------------
-- The following external packages were located on your system.
-- This installation will have the extra features provided by these packages.
-----------------------------------------------------------------------------
...
   * Soprano - Semantic Desktop Storing
   * Soprano Raptor Parser - RDF parser plugin for Soprano
   * Soprano Redland Backend - Redland storage backend for Soprano

With the ccmake-command I can better see:
 SOPRANO_CLIENT_LIBRARIES         /usr/local/lib/libsopranoclient.so
 SOPRANO_INCLUDE_DIR              /usr/local/include
 SOPRANO_INDEX_LIBRARIES          /usr/local/lib/libsopranoindex.so
 SOPRANO_LIBRARIES                /usr/local/lib/libsoprano.so
 SOPRANO_ONTO2VOCABULARYCLASS_E   /usr/local/bin/onto2vocabularyclass
 SOPRANO_PLUGIN_ROOT_DIR          /usr/local/share
 SOPRANO_SERVER_LIBRARIES         /usr/local/lib/libsopranoserver.so
 SOPRANO_SOPRANOCMD_EXECUTABLE    /usr/local/bin/sopranocmd

The cmake-command fills the SOPRANO* variables, even the version is not correct.

So the make-command shows the problem:
...                                                                                                                     
[ 20%] Building CXX object nepomuk/CMakeFiles/nepomuk.dir/types/entity.o
/home/guy-kde/trunk/src/kdelibs/nepomuk/types/entity.cpp: In member function ‘virtual bool Nepomuk::Types::EntityPrivate
::load()’:
/home/guy-kde/trunk/src/kdelibs/nepomuk/types/entity.cpp:102:31: error: ‘userVisible’ is not a member of ‘Soprano::Vocab
ulary::NAO’


- Guy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5360/#review7617
-----------------------------------------------------------


On 2010-09-15 12:26:42, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5360/
> -----------------------------------------------------------
> 
> (Updated 2010-09-15 12:26:42)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> the needed depency is 2.5.63, not 2.5.60
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/CMakeLists.txt 1175580 
> 
> Diff: http://svn.reviewboard.kde.org/r/5360/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100916/ae122a7b/attachment.htm>