Review Request: the soprano-depency for kdelibs ist not correct

[Sebastian Trueg]

> On 2010-09-15 13:15:29, Sebastian Trueg wrote:
> > Why does kdelibs need Soprano 2.5.63. It might very well be that I missed something but where is the new functionality needed?
> 
> Guy Maurel wrote:
>     OK, it is not exact enought!
>     types/entity.cpp:        else if ( property == Soprano::Vocabulary::NAO::userVisible() ) {
>     
>     entity.cpp needs userVisible from soprano/nao.h
> 
> Guy Maurel wrote:
>     It seems to be more complicated as I thought.
>     I have a soprano-version: 2.5.2. Too less!
>     But the CMake doesn't complain.
>     If I comment out the lines around
>     set(SOPRANO_MIN_VERSION "1.99") 
>     in the file cmake/modules/FindSoprano.cmake
>     I get the wished information about the OPTIONAL package ... Soprano (2.5.60 or higher)

Is this a clean build?


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5360/#review7617
-----------------------------------------------------------


On 2010-09-15 12:26:42, Guy Maurel wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5360/
> -----------------------------------------------------------
> 
> (Updated 2010-09-15 12:26:42)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> the needed depency is 2.5.63, not 2.5.60
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/CMakeLists.txt 1175580 
> 
> Diff: http://svn.reviewboard.kde.org/r/5360/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Guy
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100916/05cedc45/attachment.htm>