Review Request: Fix KUrlNavigator to send raw data (instead of KUrl) to KUriFilter (also fixes bug: 153347)

[Dawit Alemayehu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5284/#review7468
-----------------------------------------------------------


Other than the issues below, it looks good to me.


trunk/KDE/kdelibs/kfile/kurlnavigator.cpp
<http://svn.reviewboard.kde.org/r/5284/#comment7671>

    is this change necessary since the filtering is now being done in the uncommitedUrl() function called above ?



trunk/KDE/kdelibs/kfile/kurlnavigator.cpp
<http://svn.reviewboard.kde.org/r/5284/#comment7672>

    Same here as well...



trunk/KDE/kdelibs/kfile/kurlnavigator.cpp
<http://svn.reviewboard.kde.org/r/5284/#comment7670>

    Why did you exclude the call to setCheckForExecutables(false); when you moved the filtering here ?



trunk/KDE/kdelibs/kfile/kurlnavigator.cpp
<http://svn.reviewboard.kde.org/r/5284/#comment7669>

    I think you forgot to remove "bsnpfilter" here...


- Dawit


On 2010-09-07 23:27:49, Mark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5284/
> -----------------------------------------------------------
> 
> (Updated 2010-09-07 23:27:49)
> 
> 
> Review request for Dolphin and kdelibs.
> 
> 
> Summary
> -------
> 
> When a url starts with \\ it can be assumed that the user wants to access a network path. Nothing else starts with \\ anyway.
> This patch adds a KUriFilter that converts a windows network path "\\home\path\to\folder" to a samba path "smb://home/path/to/folder".
> The filter is added in KUrlNavigator thus all apps that make use of that will be affected.
> 
> OK to commit? (since i'm allowed to commit now ^_^)
> 
> 
> This addresses bug 153347.
>     https://bugs.kde.org/show_bug.cgi?id=153347
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 1172686 
> 
> Diff: http://svn.reviewboard.kde.org/r/5284/diff
> 
> 
> Testing
> -------
> 
> I tested it on some network shares to access it by the windows path names and it seems to work just fine. No issues so far.
> 
> 
> Thanks,
> 
> Mark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100907/077f9ba8/attachment.htm>