Review Request: Fix KUrlNavigator to send raw data (instead of KUrl) to KUriFilter (also fixes bug: 153347)

[Mark]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5284/
-----------------------------------------------------------

(Updated 2010-09-08 01:49:17.527659)


Review request for Dolphin and kdelibs.


Changes
-------

Updated diff with comments from Dawit Alemayehu.

About the .removeAll and .prepend question. I don't know which one is "better" here. For the moment just put your suggestion in the diff.
As for the other 2 suggestions; simply being being over eager with the fix :)


Summary
-------

When a url starts with \\ it can be assumed that the user wants to access a network path. Nothing else starts with \\ anyway.
This patch adds a KUriFilter that converts a windows network path "\\home\path\to\folder" to a samba path "smb://home/path/to/folder".
The filter is added in KUrlNavigator thus all apps that make use of that will be affected.

OK to commit? (since i'm allowed to commit now ^_^)


This addresses bug 153347.
    https://bugs.kde.org/show_bug.cgi?id=153347


Diffs (updated)
-----

  trunk/KDE/kdelibs/kfile/kurlnavigator.cpp 1172686 

Diff: http://svn.reviewboard.kde.org/r/5284/diff


Testing
-------

I tested it on some network shares to access it by the windows path names and it seems to work just fine. No issues so far.


Thanks,

Mark

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100908/52ce9b66/attachment.htm>