Moving KRatingWidget from Nepomuk to kdeui

[Frederik Gladhorn]

Am Montag 06 September 2010, 23:53:06 schrieb Albert Astals Cid:
> A Dilluns, 6 de setembre de 2010, Sebastian Trüg va escriure:
> > i am perfectly fine with that. :)
> 
> I actually found that the classes are somewhat different, e.g.
> 
> -     * Set the current rating. Calling this method will NOT trigger the
> -     * ratingChanged signal.
> +     * Set the current rating. Calling this method will trigger the
> +     * ratingChanged signal if @p rating is different from the previous
> rating.
>       */
>      void setRating( int rating );
> 
> Frederik, do you really need that behaviour to be different in knewstuff?

Actually I think the change you mentioned above is just the nepomuk version 
being more up to date. When I used this in knewstuff, I didn't think it would 
be possible to move the class.
The most significant change on my side was that I wanted a read only widget. 
But this requirement is gone, since with newer versions of attica (which will 
be used in kde 4.6, patch is already done here locally) we will have a range 
of ratings and use the widget properly.

So please just move the nepomuk version, I'll port knewstuff shortly.

Cheers
Frederik



> 
> Albert
> 
> > On 09/04/2010 10:46 PM, Albert Astals Cid wrote:
> > > I just realized  knewstuff and nepomuk have copies of the same code
> > > (KRatingWidget), as far as i remember someone (Thiago?) said it was
> > > binary compatible to move classes to an library if it was guaranteed
> > > that everyone that linked to library were the code was previous also
> > > linked to the new one, since nepomuk already links to kdeui that should
> > > be ok.
> > > 
> > > So if my remembering is correct, can i do the movement?
> > > 
> > > Albert

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100907/b24a83c5/attachment.sig>