Moving KRatingWidget from Nepomuk to kdeui

[Albert Astals Cid]

A Dilluns, 6 de setembre de 2010, Sebastian Trüg va escriure:
> i am perfectly fine with that. :)

I actually found that the classes are somewhat different, e.g. 

-     * Set the current rating. Calling this method will NOT trigger the
-     * ratingChanged signal.
+     * Set the current rating. Calling this method will trigger the
+     * ratingChanged signal if @p rating is different from the previous 
rating.
      */
     void setRating( int rating );

Frederik, do you really need that behaviour to be different in knewstuff?

Albert

> 
> On 09/04/2010 10:46 PM, Albert Astals Cid wrote:
> > I just realized  knewstuff and nepomuk have copies of the same code
> > (KRatingWidget), as far as i remember someone (Thiago?) said it was
> > binary compatible to move classes to an library if it was guaranteed
> > that everyone that linked to library were the code was previous also
> > linked to the new one, since nepomuk already links to kdeui that should
> > be ok.
> > 
> > So if my remembering is correct, can i do the movement?
> > 
> > Albert