Review Request: More user friendly error handling if a requested help docbook was not found

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5272/#review7443
-----------------------------------------------------------



trunk/KDE/kdelibs/kdoctools/kio_help.cpp
<http://svn.reviewboard.kde.org/r/5272/#comment7647>

    OK, I misunderstood the code, and you misunderstood me... let's rewind.
    
    I should have said: I don't see a reason to lookup documentationnotfound before looking documentationnotfound/index.html.
    Just get rid of the first langLookup. Even better, put the index.html into the qstring variable. Doesn't this work?
    
    const QString documentationNotFound = "khelpcenter/documentationnotfound/index.html";
    if (!langLookup(documentationNotFound).isEmpty()) {
       KUrl red;
       red.setProtocol("help");
       red.setPath(documentationNotFound);
       red.setQuery(query);
       redirection(red);
       redirect = true;
    }
    
    
    This should be equivalent to your initial patch, just without the unused first langLookup.
    Sorry for my wrong first comment.


- David


On 2010-09-06 20:30:13, Burkhard Lück wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5272/
> -----------------------------------------------------------
> 
> (Updated 2010-09-06 20:30:13)
> 
> 
> Review request for kdelibs and David Faure.
> 
> 
> Summary
> -------
> 
> In case a requested help documentation was not found for whatever reason (not installed, no documentation, wrong/missing X-DocPath etc.) KHelpcenter/Konqueror display the error message "There is no documentation available for %1." and additionally a modal dialog with the error message "The file or folder help://%1 does not exist" pops up.
> With this patch kio_help tries to load a docbook called "documentationnotfound" which will be installed with the khelpcenter documentation from kdebase/runtime. In this docbook the user will find information how to solve this issue and links to kde documentation online (docs.kde.org/userbase/forum).
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdoctools/kio_help.cpp 1170669 
> 
> Diff: http://svn.reviewboard.kde.org/r/5272/diff
> 
> 
> Testing
> -------
> 
> With this patch and no docbook "documentationnotfound" installed no change to the current situation, with an installed docbook "documentationnotfound" this is displayed as expected.
> 
> 
> Thanks,
> 
> Burkhard
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100906/4fb121fe/attachment.htm>