Review Request: More user friendly error handling if a requested help docbook was not found

[Burkhard Lück]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5272/
-----------------------------------------------------------

(Updated 2010-09-06 20:30:13.644101)


Review request for kdelibs and David Faure.


Changes
-------

add missing if(empty) call requested by David Faure


Summary
-------

In case a requested help documentation was not found for whatever reason (not installed, no documentation, wrong/missing X-DocPath etc.) KHelpcenter/Konqueror display the error message "There is no documentation available for %1." and additionally a modal dialog with the error message "The file or folder help://%1 does not exist" pops up.
With this patch kio_help tries to load a docbook called "documentationnotfound" which will be installed with the khelpcenter documentation from kdebase/runtime. In this docbook the user will find information how to solve this issue and links to kde documentation online (docs.kde.org/userbase/forum).


Diffs (updated)
-----

  trunk/KDE/kdelibs/kdoctools/kio_help.cpp 1170669 

Diff: http://svn.reviewboard.kde.org/r/5272/diff


Testing
-------

With this patch and no docbook "documentationnotfound" installed no change to the current situation, with an installed docbook "documentationnotfound" this is displayed as expected.


Thanks,

Burkhard

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100906/325cbd40/attachment.htm>