Review Request: Fix KArchiveFile::copyTo() for large files

[David Faure]

On Friday 03 September 2010, Gökçen Eraslan wrote:
> 17 Ağustos 2010 Salı günü (saat 23:36:24) David Faure şunları yazmıştı:
> > Ship it!
> > 
> > 
> > Thanks, please commit.
> > 
> > - David
> > This change has broken extracting zip files via KZip class.

Indeed.

Good: this was actually caught by karchivetest!
QFATAL : KArchiveTest::testZipCopyTo() ASSERT: "n == currentChunkSize" in file 
/d/kde/src/t/kdelibs/kdecore/io/karchive.cpp, line 683

Bad: Christoph didn't actually run karchivetest :)

Reason for the bug: the rewrite short-circuited the call to the virtual 
createDevice(), so now copyTo was trying to extract raw compressed data, in 
the case of ZIP.

Fixed.
(r1171340 in trunk, r1171342 in 4.5 branch)

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).