Review Request: Fix KArchiveFile::copyTo() for large files

Gökçen Eraslan gokcen at pardus.org.tr
Fri Sep 3 12:40:33 BST 2010


17 Ağustos 2010 Salı günü (saat 23:36:24) David Faure şunları yazmıştı:
> Ship it!
> 
> 
> Thanks, please commit.
> 
> - David

This change has broken extracting zip files via KZip class. For example try to 
install attached plasmoid using:

plasmapkg -i 118636-day-and-night.plasmoid

You will see:

"KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 1: 
" Invalid entry (missing ']')·                                                                                                                                       
"KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 2: 
" Invalid entry (missing '=')·                                                                                                                                       
"KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 3: 
" Invalid entry (missing '=')·                                                                                                                                       
"KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 4: 
" Invalid entry (missing ']')·                                                                                                                                       
"KConfigIni: In file /tmp/kde-gokcen/plasmapkgeu4DbG/metadata.desktop, line 5: 
" Invalid entry (missing ']')·                                                                                                                                       
plasmapkg(7657)/libplasma Plasma::Package::installPackage: Package plugin name 
not specified·                                                                                                                                                       

since metadata.desktop is garbage. Garbage metadata.desktop is also attached. 
When I recompile 4.5.1 without this commit I can normally install this 
plasmoid via plasmapkg.

-- 
Gökçen Eraslan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 118636-day-and-night.plasmoid
Type: application/x-plasma
Size: 26507 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100903/fa8612fe/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: metadata.desktop
Type: application/x-desktop
Size: 1156 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100903/fa8612fe/attachment-0001.bin>


More information about the kde-core-devel mailing list