Solid upower backend and kdeinit crash...
adawit at kde.org
Fri Oct 29 21:28:01 BST 2010
On Fri, Oct 29, 2010 at 3:48 PM, Chani <chanika at gmail.com> wrote:
>> > I'd probably have to read the code to know whether it was sane (and I
>> > can't tell what constructor you're referring to)
> oh jeez, it doesn't init m_backlight if it doesn't get far enough... it should
> init that to *something*. especially since other functions are using it. meep.
> hmm, and m_isSuppported is logically equivalent to (m_resources != null) so
> it's redundant - but harmless.
yep... there is no need for that flag at all. It is redundant.
> I say, make sure m_backlight has a default value up there where m_resources is
> set null, and then add an isSupported check at the top of *every* function in
> there (well, besides itself of course ;)
Or set the m_backlight as you stated, get rid of the unnecessary
m_isSupported flag altogether
and simply check m_resources before using it, as in the attached patch... :)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 3121 bytes
Desc: not available
More information about the kde-core-devel