Solid upower backend and kdeinit crash...

[Chani]

> 
> > I'd probably have to read the code to know whether it was sane (and I
> > can't tell what constructor you're referring to)
> 
> kdebase/workspace/powerdevil/daemon/backends/upower/xrandrbrightness.cpp

oh jeez, it doesn't init m_backlight if it doesn't get far enough... it should 
init that to *something*. especially since other functions are using it. meep.

hmm, and m_isSuppported is logically equivalent to (m_resources != null) so 
it's redundant - but harmless.

I say, make sure m_backlight has a default value up there where m_resources is 
set null, and then add an isSupported check at the top of *every* function in 
there (well, besides itself of course ;)

-- 
Chani
http://chani.ca
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: This is a digitally signed message part.
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101029/db3dfe06/attachment.sig>