Review Request: Add support for parsing relative present actions in notification contexts

[Jacopo De Simoi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5631/
-----------------------------------------------------------

(Updated 2010-10-26 08:12:14.948960)


Review request for kdelibs and Olivier Goffart.


Changes
-------

Fixed code as Oliver suggested. I must admit it is much better now :P


Summary
-------

This patch allows to specify, for some specific notification contexts, present actions that should be either added or removed with 
respect to the default (i.e. without context) ones. E.g. one could write notifyrc files containing:

[Event/someevent/presentation/fullscreen]
Action=-Sound|-Popup

[Event/someevent/quietbutverbose/whatever]
Action=+Popup|-Sound

[Event/someevent/morespecificnotifier/present]
Action=-Popup

This lets the user to customize non-contextualized actions via the usual interface, but at the same time allows some control by the
developer in some particular situations.

The patch changes knotifyconfig.cpp in order to parse contextualized actions also in the system-wide file and includes some basic 
validity check in such a way to recognize invalid expressions such as:

Action=-Popup|Sound

I don't know where to document this behaviour; any help on that is most appreciated.
Thanks!


Diffs (updated)
-----

  trunk/KDE/kdebase/runtime/knotify/knotify.cpp 1189669 
  trunk/KDE/kdebase/runtime/knotify/knotifyconfig.cpp 1189669 

Diff: http://svn.reviewboard.kde.org/r/5631/diff


Testing
-------


Thanks,

Jacopo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101026/f3f069df/attachment.htm>