<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5631/">http://svn.reviewboard.kde.org/r/5631/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and Olivier Goffart.</div>
<div>By Jacopo De Simoi.</div>
<p style="color: grey;"><i>Updated 2010-10-26 08:12:14.948960</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fixed code as Oliver suggested. I must admit it is much better now :P</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch allows to specify, for some specific notification contexts, present actions that should be either added or removed with
respect to the default (i.e. without context) ones. E.g. one could write notifyrc files containing:
[Event/someevent/presentation/fullscreen]
Action=-Sound|-Popup
[Event/someevent/quietbutverbose/whatever]
Action=+Popup|-Sound
[Event/someevent/morespecificnotifier/present]
Action=-Popup
This lets the user to customize non-contextualized actions via the usual interface, but at the same time allows some control by the
developer in some particular situations.
The patch changes knotifyconfig.cpp in order to parse contextualized actions also in the system-wide file and includes some basic
validity check in such a way to recognize invalid expressions such as:
Action=-Popup|Sound
I don't know where to document this behaviour; any help on that is most appreciated.
Thanks!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/KDE/kdebase/runtime/knotify/knotify.cpp <span style="color: grey">(1189669)</span></li>
<li>trunk/KDE/kdebase/runtime/knotify/knotifyconfig.cpp <span style="color: grey">(1189669)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5631/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>