Review Request: Menubar and statusbar visibility actions: replace togglable "show" actions with "show/hide" actions

[Thomas Friedrichsmeier]

> On 2010-10-15 21:05:10, David Faure wrote:
> > (and if this is all about new classes or standard actions which work out of the box, how is it a problem for apps that are not in kde svn? they'll keep working...)

True, we are not talking about a grave problem, here. But this is effectively changing the HIG (or at leat the de-facto standard) for this type of action. And it means, if we happen to use any other similar actions, we have the choice between:
- designing them to be consistent with KDE < 4.6
- designing them to be consistent with KDE >= 4.5
- wrapping each of them in a version check.


@Aurlien:
> I don't think it should prevent us from fixing bugs

No, it should not. But so far my feeling is that this debate is about differing taste, not about a real bug. Either way, this is not going to be the end of the world for me. My rant was somewhat ill-directed, as it's only partially about this specific request. It is my impression that these more subtle points of backwards compatibility are ignored much too often, in general.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5622/#review8171
-----------------------------------------------------------


On 2010-10-15 22:00:53, Aurélien Gâteau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5622/
> -----------------------------------------------------------
> 
> (Updated 2010-10-15 22:00:53)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> The standard actions to toggle the visibility of the menubar and the statusbar are togglable "show" actions: their label is always "show {menu,status}bar" and they have a checkbox next to them. This means when the user wants to hide the statusbar, he must click an item which says "[x] Show Statusbar". I believe this is less intuitive than if the item label were "Hide Statusbar".
> 
> Attached patch implements this by introducing KStandardAction::showHideMenubar(), KStandardAction::showHideStatusbar() and using showHideStatusbar() in KXmlGuiWindow. It also deprecates KStandardAction::showMenubar() and KStandardAction::hideMenubar().
> (I already have a patch for Konqueror to make use of KStandardAction::showHideMenubar() and will probably patch other applications if this request is approved)
> 
> 
> Diffs
> -----
> 
>   trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h 1185607 
>   trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp 1185607 
>   trunk/KDE/kdelibs/kdeui/xmlgui/kxmlguiwindow.cpp 1185607 
> 
> Diff: http://svn.reviewboard.kde.org/r/5622/diff
> 
> 
> Testing
> -------
> 
> Tested with Konqueror, KWrite and other KDE applications (more patches to come to provide consistency among applications)
> 
> 
> Thanks,
> 
> Aurélien
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101016/9a26c701/attachment.htm>