Review Request: Menubar and statusbar visibility actions: replace togglable "show" actions with "show/hide" actions

[Aurélien Gâteau]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5622/
-----------------------------------------------------------

(Updated 2010-10-15 22:00:53.789620)


Review request for kdelibs.


Summary
-------

The standard actions to toggle the visibility of the menubar and the statusbar are togglable "show" actions: their label is always "show {menu,status}bar" and they have a checkbox next to them. This means when the user wants to hide the statusbar, he must click an item which says "[x] Show Statusbar". I believe this is less intuitive than if the item label were "Hide Statusbar".

Attached patch implements this by introducing KStandardAction::showHideMenubar(), KStandardAction::showHideStatusbar() and using showHideStatusbar() in KXmlGuiWindow. It also deprecates KStandardAction::showMenubar() and KStandardAction::hideMenubar().
(I already have a patch for Konqueror to make use of KStandardAction::showHideMenubar() and will probably patch other applications if this request is approved)


Diffs
-----

  trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h 1185607 
  trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp 1185607 
  trunk/KDE/kdelibs/kdeui/xmlgui/kxmlguiwindow.cpp 1185607 

Diff: http://svn.reviewboard.kde.org/r/5622/diff


Testing
-------

Tested with Konqueror, KWrite and other KDE applications (more patches to come to provide consistency among applications)


Thanks,

Aurélien

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101015/8d90d46e/attachment.htm>