Review Request: Allow hiding icons in menus

[Christoph Feck]

> On 2010-10-15 22:53:58, David Faure wrote:
> > /trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp, line 1119
> > <http://svn.reviewboard.kde.org/r/5609/diff/1/?file=39170#file39170line1119>
> >
> >     This default value surprises me. It basically says "by default, whatever Qt does, it must be wrong, let me toggle it".
> >     
> >     I think you meant cg.readEntry("ShowIconsInMenuItems", true), which matches the current default behavior and the default value in the similar KCM code.

It says "use the current Qt value as default". Note the "Dont" in the attribute name.


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5609/#review8174
-----------------------------------------------------------


On 2010-10-12 04:58:51, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5609/
> -----------------------------------------------------------
> 
> (Updated 2010-10-12 04:58:51)
> 
> 
> Review request for kdelibs and Hugo Pereira Da Costa.
> 
> 
> Summary
> -------
> 
> The first part of this patch makes the Qt::AA_DontShowIconsInMenus configurable in kdelibs via a KDE config entry.
> 
> The second part exposes this config entry in the Styles KCM, just right between the settings to hide icons on buttons or toolbars.
> 
> Note that GNOME also has this configuration option.
> 
> 
> This addresses bug 253339.
>     https://bugs.kde.org/show_bug.cgi?id=253339
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/style/finetuning.ui 1184959 
>   /trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp 1184959 
>   /trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1184959 
> 
> Diff: http://svn.reviewboard.kde.org/r/5609/diff
> 
> 
> Testing
> -------
> 
> Hiding the menu icons works with all styles (even pure Qt styles), because Qt itself respects this attribute when setting up the menus.
> 
> The only "bug" is a missing dialog informing the user that changing this option only affects applications after restarting (same as Xft font settings or locale options). But before I add that, I want some feedback.
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101016/db0367e4/attachment.htm>