Review Request: Allow hiding icons in menus

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5609/#review8174
-----------------------------------------------------------


So some people don't like the nice shiny icons in menu items? That's sad :-)

Anyway, patch looks good, except for one bug. Feel free to commit if you agree with the suggested change.


/trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp
<http://svn.reviewboard.kde.org/r/5609/#comment8446>

    This default value surprises me. It basically says "by default, whatever Qt does, it must be wrong, let me toggle it".
    
    I think you meant cg.readEntry("ShowIconsInMenuItems", true), which matches the current default behavior and the default value in the similar KCM code.


- David


On 2010-10-12 04:58:51, Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5609/
> -----------------------------------------------------------
> 
> (Updated 2010-10-12 04:58:51)
> 
> 
> Review request for kdelibs and Hugo Pereira Da Costa.
> 
> 
> Summary
> -------
> 
> The first part of this patch makes the Qt::AA_DontShowIconsInMenus configurable in kdelibs via a KDE config entry.
> 
> The second part exposes this config entry in the Styles KCM, just right between the settings to hide icons on buttons or toolbars.
> 
> Note that GNOME also has this configuration option.
> 
> 
> This addresses bug 253339.
>     https://bugs.kde.org/show_bug.cgi?id=253339
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdebase/workspace/kcontrol/style/finetuning.ui 1184959 
>   /trunk/KDE/kdebase/workspace/kcontrol/style/kcmstyle.cpp 1184959 
>   /trunk/KDE/kdelibs/kdeui/kernel/kglobalsettings.cpp 1184959 
> 
> Diff: http://svn.reviewboard.kde.org/r/5609/diff
> 
> 
> Testing
> -------
> 
> Hiding the menu icons works with all styles (even pure Qt styles), because Qt itself respects this attribute when setting up the menus.
> 
> The only "bug" is a missing dialog informing the user that changing this option only affects applications after restarting (same as Xft font settings or locale options). But before I add that, I want some feedback.
> 
> 
> Thanks,
> 
> Christoph
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101015/cdfd5386/attachment.htm>