Review Request: add QT_IMPORTS_DIR to cmake

[Marco Martin]

> On 2010-10-07 18:18:13, Alexander Neundorf wrote:
> > Looks ok.
> > Maybe the variable could be named QT_QML_IMPORTS_DIR or something like this, to make it more descriptive ?
> > Please post this also to the cmake bugtracker (http://public.kitware.com/Bug), I would prefer if Clinton, the upstream FindQt4.cmake maintainer would also review it.
> > 
> > Alex
> >
> 
> Marco Martin wrote:
>     ok, changed it.
>     I reported the issue at
>     http://public.kitware.com/Bug/view.php?id=11301

Now an adapted version has been merged upstream.
what is the procedure to get the patch into the kde version?
adapt the patch or move down with the other the recent changes from the upstream file?


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5541/#review8026
-----------------------------------------------------------


On 2010-10-07 19:12:38, Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5541/
> -----------------------------------------------------------
> 
> (Updated 2010-10-07 19:12:38)
> 
> 
> Review request for kdelibs and Alexander Neundorf.
> 
> 
> Summary
> -------
> 
> this defines a new cmake variable, QT_IMPORTS_DIR
> it's used by QML for extra plugins and is usually /usr/imports
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/cmake/modules/FindQt4.cmake 1179394 
> 
> Diff: http://svn.reviewboard.kde.org/r/5541/diff
> 
> 
> Testing
> -------
> 
> used the new variable to install new plugins
> 
> 
> Thanks,
> 
> Marco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101010/26899c23/attachment.htm>