Review Request: create a menu entry in the help menu to enable all the "do not ask again"

Pino Toscano pino at kde.org
Fri Oct 8 15:43:37 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5469/#review8041
-----------------------------------------------------------



/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h
<http://svn.reviewboard.kde.org/r/5469/#comment8269>

    Missing "@since 4.6".



/trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h
<http://svn.reviewboard.kde.org/r/5469/#comment8268>

    Missing "@since 4.6".



/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h
<http://svn.reviewboard.kde.org/r/5469/#comment8270>

    Missing "@since 4.6".



/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h
<http://svn.reviewboard.kde.org/r/5469/#comment8271>

    Missing "@since 4.6".



/trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp
<http://svn.reviewboard.kde.org/r/5469/#comment8272>

    Maybe it would be just me, but I'd do such style changes in a different commit than the feature commit.


- Pino


On 2010-09-29 17:17:09, Jaime Torres wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5469/
> -----------------------------------------------------------
> 
> (Updated 2010-09-29 17:17:09)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Create a menu entry in the help menu to enable again all the "do not ask again" messagebox for that application.
> Probably there is a better description for the menu entry (but I can not find it).
> Also, the icon for the entry is missing (or does it need an icon?)
> 
> I hope this is Binary Compatible.
> 
> Of course, when I'll commit, I'll remove all the trailing spaces (How can I see them before doing a post-review?).
> 
> 
> This addresses bug 190238.
>     https://bugs.kde.org/show_bug.cgi?id=190238
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/widgets/khelpmenu.cpp 1180729 
>   /trunk/KDE/kdelibs/kdeui/xmlgui/ui_standards.rc 1180729 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction_p.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction.h 1180729 
>   /trunk/KDE/kdelibs/kdeui/actions/kstandardaction.cpp 1180729 
> 
> Diff: http://svn.reviewboard.kde.org/r/5469/diff
> 
> 
> Testing
> -------
> 
> konsole ask again "Do you have multiplies tabs, do you want to close,....."
> 
> 
> Thanks,
> 
> Jaime
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101008/e9f1cd48/attachment.htm>


More information about the kde-core-devel mailing list