I was kinda bored

Maksim Orlovich mo85 at cornell.edu
Thu Oct 7 17:32:47 BST 2010

Thanks. Looks cool, and the diff looks pretty good (though I can't
check the visual stuff in my head)... A couple things I noticed from
reading it, though:

1) Don't change misc/htmlnames.{h/cpp} directly. Rather edit
misc/htmlattrs.in and re-run
misc/gennames.py. Then "enjoy" a full recompile...

+        if ((int)m_numberMin == m_numberMin)
+            ok = ((int)tmp == tmp);

Probably need to check the original ok here, too.
It's probably also worth checking whether something like
setAttribute("min", "monkeys!") is supposed to reset the value to default
or not.

3) RenderNumberEdit::upateFromElement:() needs to update min/max/step as well

Also, it'd probably be better to e-mail kfm-devel with stuff like
this, especially if you use a vague title ;-).


On 10/6/10, Rolf Eike Beer <kde at opensource.sf-tec.de> wrote:
> I was hacking for something like 3 or 4 hours and came up with this
> implementation of the "new" HTML5 <input type="number"> field. I have no
> idea
> if that is the right way to do it, I must also confess that most of the code
> is copy&paste from the normal input fields. The only real testing I did was
> using http://diveintohtml5.org/examples/input-type-number-min-max-step.html
> which seems to work as expected.
> If someone with any insight in KHTML could take a look if this is anything
> close to a sane implementation I would be happy to see something like this
> going into KHTML for KDE 4.6. If it covers only half of the cases it still
> makes the users life easier than the pure text field ;)
> Eike

More information about the kde-core-devel mailing list