Review Request: Minor GUI change to rename/overwrite dialog window

[Steven Sroka]

> On 2010-10-06 09:35:05, David Faure wrote:
> > Well, I would have really preferred that the astyle formatting was done in another commit; the patch is hard to read now, and svn annotate will be confusing. But nevermind, too late now. (BTW did you run kdesdk/scripts/astyle-kdelibs or something different?)
> > 
> > Anyway, patch seems ok now, except for the blank label. If you can test without it and it's all fine, I'll commit the patch. Thanks!

"did you run kdesdk/scripts/astyle-kdelibs"   -Yes, thats exactly the one I ran :)

I will work on the blank label removal now.


- Steven


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5443/#review7989
-----------------------------------------------------------


On 2010-10-06 02:43:12, Steven Sroka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5443/
> -----------------------------------------------------------
> 
> (Updated 2010-10-06 02:43:12)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This is my first submission to KDE. If I am missing something, don't hesitate to tell me.
> 
> This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.
> 
> 
> This addresses bug 238942.
>     https://bugs.kde.org/show_bug.cgi?id=238942
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.h 1181964 
>   /trunk/KDE/kdelibs/kio/kio/renamedialog.cpp 1181964 
> 
> Diff: http://svn.reviewboard.kde.org/r/5443/diff
> 
> 
> Testing
> -------
> 
> Correctly Compiled.
> "Eye ball'ed" Code.
> Ran code with all possible '_mode' as per http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
> Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.
> 
> (I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on bugs.kde.org soon)
> 
> 
> Screenshots
> -----------
> 
> KDE Trunk - Bug
>   http://svn.reviewboard.kde.org/r/5443/s/526/
> *New - File to File
>   http://svn.reviewboard.kde.org/r/5443/s/527/
> KDE 4.5 - File to File
>   http://svn.reviewboard.kde.org/r/5443/s/528/
> Revision 5 Screenshot
>   http://svn.reviewboard.kde.org/r/5443/s/529/
> New warning
>   http://svn.reviewboard.kde.org/r/5443/s/530/
> 
> 
> Thanks,
> 
> Steven
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101006/0915e441/attachment.htm>