<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5443/">http://svn.reviewboard.kde.org/r/5443/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 6th, 2010, 9:35 a.m., <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Well, I would have really preferred that the astyle formatting was done in another commit; the patch is hard to read now, and svn annotate will be confusing. But nevermind, too late now. (BTW did you run kdesdk/scripts/astyle-kdelibs or something different?)
Anyway, patch seems ok now, except for the blank label. If you can test without it and it's all fine, I'll commit the patch. Thanks!</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"did you run kdesdk/scripts/astyle-kdelibs" -Yes, thats exactly the one I ran :)
I will work on the blank label removal now.</pre>
<br />
<p>- Steven</p>
<br />
<p>On October 6th, 2010, 2:43 a.m., Steven Sroka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Steven Sroka.</div>
<p style="color: grey;"><i>Updated 2010-10-06 02:43:12</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is my first submission to KDE. If I am missing something, don't hesitate to tell me.
This is a slight GUI change to the rename/overwrite dialog window, just to make it more user friendly.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Correctly Compiled.
"Eye ball'ed" Code.
Ran code with all possible '_mode' as per http://api.kde.org/4.5-api/kdelibs-apidocs/kio/html/namespaceKIO.html#bac5df6792cd3426582dbfd1af706bff
Ran many possible combinations (most if not all) -> move folder to folder, file to file, file to folder, folder to file, and paid attention to creation date.
(I actually found a bug with the preview picture that is shown in a certain scenario - I will create a bug notice for it on bugs.kde.org soon)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=238942">238942</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/kio/kio/renamedialog.h <span style="color: grey">(1181964)</span></li>
<li>/trunk/KDE/kdelibs/kio/kio/renamedialog.cpp <span style="color: grey">(1181964)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5443/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5443/s/526/"><img src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="KDE Trunk - Bug" /></a>
<a href="http://svn.reviewboard.kde.org/r/5443/s/527/"><img src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="*New - File to File" /></a>
<a href="http://svn.reviewboard.kde.org/r/5443/s/528/"><img src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="KDE 4.5 - File to File" /></a>
<a href="http://svn.reviewboard.kde.org/r/5443/s/529/"><img src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="Revision 5 Screenshot" /></a>
<a href="http://svn.reviewboard.kde.org/r/5443/s/530/"><img src="http://svn.reviewboard.kde.org" style="border: 1px black solid;" alt="New warning" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>