Review Request: KHolidays: New Holiday Region Selection widget

[Allen Winter]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5518/#review7945
-----------------------------------------------------------


the kdepimlibs indentation level is 2, not 4.

I really like this.


/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.cpp
<http://svn.reviewboard.kde.org/r/5518/#comment8210>

    Please make sure that all column headers have a tooltip and a whatsthis



/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.cpp
<http://svn.reviewboard.kde.org/r/5518/#comment8208>

    please add a whatsthis



/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.cpp
<http://svn.reviewboard.kde.org/r/5518/#comment8209>

    please add a whatsthis


- Allen


On 2010-10-02 18:21:32, John Layt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5518/
> -----------------------------------------------------------
> 
> (Updated 2010-10-02 18:21:32)
> 
> 
> Review request for kdelibs and KDE PIM.
> 
> 
> Summary
> -------
> 
> Implement a standard widget in the KHolidays library for clients to use to allow users to select holiday regions to be displayed.  The widget provides a number of modes and features to fit most use case scenarios I can think of:
> * A display only mode
> * A single Holiday Region selection mode
> * A multiple Holiday Region selection mode with optional secondary selection for Days Off / preferred Holiday Region
> * A search line
> * Ability to modify level of detail displayed when space is limited
> 
> Some points to think about:
> 1) I've implemented Qt Designer plugin support for the widget using a KHolidays specific plugin, but should the Designer support actually be at kdepimlibs level instead, i.e. all kdepimlibs widgets in a  single shared plugin?
> 2) Naming of the widget, enum and api calls
> 3) The layout of the selection boxes and columns
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdepimlibs/includes/KHolidays/HolidayRegionSelector PRE-CREATION 
>   /trunk/KDE/kdepimlibs/kholidays/CMakeLists.txt 1180311 
>   /trunk/KDE/kdepimlibs/kholidays/holidayregionselector.h PRE-CREATION 
>   /trunk/KDE/kdepimlibs/kholidays/holidayregionselector.cpp PRE-CREATION 
>   /trunk/KDE/kdepimlibs/kholidays/holidayregionselector.ui PRE-CREATION 
>   /trunk/KDE/kdepimlibs/kholidays/kholidays.widgets PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/5518/diff
> 
> 
> Testing
> -------
> 
> Test client implementation done in the Plasma clock/calendar.
> 
> 
> Screenshots
> -----------
> 
> Widget example
>   http://svn.reviewboard.kde.org/r/5518/s/523/
> 
> 
> Thanks,
> 
> John
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101002/b128dc0d/attachment.htm>