<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5518/">http://svn.reviewboard.kde.org/r/5518/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">the kdepimlibs indentation level is 2, not 4.
I really like this.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5518/diff/1/?file=38839#file38839line102" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QTreeWidgetItem *HolidayRegionSelector::Private::findItem( const QString &holidayRegionCode )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">102</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">void</span> <span class="n">HolidayRegionSelector</span><span class="o">::</span><span class="n">Private</span><span class="o">::</span><span class="n">initItem</span><span class="p">(</span> <span class="n">QTreeWidgetItem</span> <span class="o">*</span><span class="n">listItem</span><span class="p">,</span> <span class="n">HolidayRegion</span> <span class="o">*</span><span class="n">region</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please make sure that all column headers have a tooltip and a whatsthis</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5518/diff/1/?file=38839#file38839line107" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QTreeWidgetItem *HolidayRegionSelector::Private::findItem( const QString &holidayRegionCode )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">107</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">listItem</span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span> <span class="n">Private</span><span class="o">::</span><span class="n">SelectColumn</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Select to use Holiday Region"</span><span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please add a whatsthis</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="/r/5518/diff/1/?file=38839#file38839line109" style="color: black; font-weight: bold; text-decoration: underline;">/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QTreeWidgetItem *HolidayRegionSelector::Private::findItem( const QString &holidayRegionCode )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">109</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">listItem</span><span class="o">-></span><span class="n">setToolTip</span><span class="p">(</span> <span class="n">Private</span><span class="o">::</span><span class="n">SecondaryColumn</span><span class="p">,</span> <span class="n">i18n</span><span class="p">(</span><span class="s">"Select to use Holiday Region for Days Off"</span><span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">please add a whatsthis</pre>
</div>
<br />
<p>- Allen</p>
<br />
<p>On October 2nd, 2010, 6:21 p.m., John Layt wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and KDE PIM.</div>
<div>By John Layt.</div>
<p style="color: grey;"><i>Updated 2010-10-02 18:21:32</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Implement a standard widget in the KHolidays library for clients to use to allow users to select holiday regions to be displayed. The widget provides a number of modes and features to fit most use case scenarios I can think of:
* A display only mode
* A single Holiday Region selection mode
* A multiple Holiday Region selection mode with optional secondary selection for Days Off / preferred Holiday Region
* A search line
* Ability to modify level of detail displayed when space is limited
Some points to think about:
1) I've implemented Qt Designer plugin support for the widget using a KHolidays specific plugin, but should the Designer support actually be at kdepimlibs level instead, i.e. all kdepimlibs widgets in a single shared plugin?
2) Naming of the widget, enum and api calls
3) The layout of the selection boxes and columns
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test client implementation done in the Plasma clock/calendar.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdepimlibs/includes/KHolidays/HolidayRegionSelector <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdepimlibs/kholidays/CMakeLists.txt <span style="color: grey">(1180311)</span></li>
<li>/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdepimlibs/kholidays/holidayregionselector.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdepimlibs/kholidays/kholidays.widgets <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5518/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://svn.reviewboard.kde.org/r/5518/s/523/"><img src="http://svn.reviewboard.kde.org/media/uploaded/images/2010/10/02/HolidaysMultipleSelector_400x100.jpg" style="border: 1px black solid;" alt="Widget example" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>