Review Request: KDateEdit moving into kdelibs

[Kevin Ottens]

> On 2010-11-29 22:24:15, John Layt wrote:
> > Before I get stuck in, three points:
> > 
> > 1) Screenshots?
> > 2) API freeze: this will need explicit approval from the release team as well as k-c-d.  What's the feeling on this?
> > 3) String freeze: this will need an exemption for any new strings (moving them from elsewhere still needs approval afaik).
> >

1) Thought it wasn't necessary, visually it's exactly the good old date edit we find in quite a few KDE apps. Except that for now they all copy the code.
2) It's still on discussion on r-t which I contacted first.
3) Indeed, thought about this one only this morning, that in my opinion the first blocker.


- Kevin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6014/#review9046
-----------------------------------------------------------


On 2010-11-29 22:11:34, Kevin Ottens wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6014/
> -----------------------------------------------------------
> 
> (Updated 2010-11-29 22:11:34)
> 
> 
> Review request for kdelibs and KDE PIM.
> 
> 
> Summary
> -------
> 
> For a very long time now there's been a KDateEdit widget cooking up in kdepim. It's in fact a popular one, and I'm aware of around half a dozen (sometimes modified) copies of that widget. One of the most advanced fork is in Skrooge ATM. During the latest KDE Hacking Session in Toulouse, I sat down with the Skrooge maintainer and produced a refactored version of KDateEdit which also cover their needs.
> 
> This patch is about introducing this widget in kdeui. It basically comes with three new classes:
>  - KDateEdit itself;
>  - KDatePickerPopup used by KDateEdit to popup a calendar picker;
>  - KDateValidator used by KDateEdit to validate the input, it's made public as some of the fixup behavior can be tuned.
> 
> Note that KDateTable already exposed a class named KDateValidator (much less advanced), so I took care of copying the extra method the former KDateValidator was exposing for BC reasons.
> 
> I'm aiming for inclusion in 4.6, so a prompt review would be welcome. Thanks in advance. ;-)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/includes/CMakeLists.txt 1201925 
>   /trunk/KDE/kdelibs/includes/KDateEdit PRE-CREATION 
>   /trunk/KDE/kdelibs/includes/KDatePickerPopup PRE-CREATION 
>   /trunk/KDE/kdelibs/includes/KDateValidator 1201925 
>   /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1201925 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdateedit.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.h 1201925 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdatetable.cpp 1201925 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.h PRE-CREATION 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.cpp PRE-CREATION 
>   /trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator_p.h PRE-CREATION 
> 
> Diff: http://svn.reviewboard.kde.org/r/6014/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101130/21fd341c/attachment.htm>