<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6014/">http://svn.reviewboard.kde.org/r/6014/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 29th, 2010, 10:24 p.m., <b>John Layt</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before I get stuck in, three points:
1) Screenshots?
2) API freeze: this will need explicit approval from the release team as well as k-c-d. What's the feeling on this?
3) String freeze: this will need an exemption for any new strings (moving them from elsewhere still needs approval afaik).
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">1) Thought it wasn't necessary, visually it's exactly the good old date edit we find in quite a few KDE apps. Except that for now they all copy the code.
2) It's still on discussion on r-t which I contacted first.
3) Indeed, thought about this one only this morning, that in my opinion the first blocker.</pre>
<br />
<p>- Kevin</p>
<br />
<p>On November 29th, 2010, 10:11 p.m., Kevin Ottens wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and KDE PIM.</div>
<div>By Kevin Ottens.</div>
<p style="color: grey;"><i>Updated 2010-11-29 22:11:34</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For a very long time now there's been a KDateEdit widget cooking up in kdepim. It's in fact a popular one, and I'm aware of around half a dozen (sometimes modified) copies of that widget. One of the most advanced fork is in Skrooge ATM. During the latest KDE Hacking Session in Toulouse, I sat down with the Skrooge maintainer and produced a refactored version of KDateEdit which also cover their needs.
This patch is about introducing this widget in kdeui. It basically comes with three new classes:
- KDateEdit itself;
- KDatePickerPopup used by KDateEdit to popup a calendar picker;
- KDateValidator used by KDateEdit to validate the input, it's made public as some of the fixup behavior can be tuned.
Note that KDateTable already exposed a class named KDateValidator (much less advanced), so I took care of copying the extra method the former KDateValidator was exposing for BC reasons.
I'm aiming for inclusion in 4.6, so a prompt review would be welcome. Thanks in advance. ;-)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/KDE/kdelibs/includes/CMakeLists.txt <span style="color: grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/includes/KDateEdit <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/KDatePickerPopup <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/includes/KDateValidator <span style="color: grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/CMakeLists.txt <span style="color: grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdateedit.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdateedit.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatepickerpopup.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatetable.h <span style="color: grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatetable.cpp <span style="color: grey">(1201925)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>/trunk/KDE/kdelibs/kdeui/widgets/kdatevalidator_p.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6014/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>