Review Request: Fix for "The name org.kde.kwalletd was not provided by any .service files" errors about kwallet

[Gökcen Eraslan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5885/
-----------------------------------------------------------

(Updated 2010-11-17 11:04:26.001050)


Review request for kdelibs and David Faure.


Summary
-------

In KWallet::Wallet class (of kdelibs/kdeui/util/kwallet.cpp), validity of some DBus replies from kwalletd are not checked. Since kwallet clients like kwalletmanager do not check the validity of replies, client behave weird sometimes. For example if I disable kwallet and open kwalletmanager, I see a wallet named "The name org.kde.kwalletd was not provided by any .service files". Also another weird thing is that wallet seems open. 

This patch add more validity checks to kwalletd dbus calls, to prevent weird behaviours of kwallet clients. This patch may also fix some bugs related to kwalletmanager or kwalletd.


Diffs
-----

  svn://anonsvn.kde.org/home/kde/trunk/KDE/kdelibs/kdeui/util/kwallet.cpp 1198078 

Diff: http://svn.reviewboard.kde.org/r/5885/diff


Testing
-------

Tested with kwalletmanager of KDE 4.5.3, but patch is the same for trunk.


Screenshots
-----------

Before
  http://svn.reviewboard.kde.org/r/5885/s/558/
After
  http://svn.reviewboard.kde.org/r/5885/s/559/


Thanks,

Gökcen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20101117/0ab72650/attachment.htm>