Issues with Solid from trunk and qtcreator 2.0.1...

Dawit A adawit at kde.org
Thu Nov 4 17:58:09 GMT 2010


BTW, I noticed a couple of things in UDisksManager that I want to ask
about... The first issue is why does a device that has its
"DeviceIsOpticalDisc" property set to true inserted into the
m_deviceCache 2x, once normally and once with ":media" attached to it
? The second issue is why even bother with doing that in the first
place ? I mean check for that property in allDevices() ? Why could not
that check be done in slotDeviceAdded() ? That would save on the
unnecessary creation and querying of temporary UDisksDevice objects
for every single device that was enumerated, which ends up with
expensive dbus calls everytime ?




More information about the kde-core-devel mailing list