Review Request: Fix vertical positionning of "click" message in klineedit

[Hugo Pereira Da Costa]

> On 2010-05-22 09:18:33, Christoph Feck wrote:
> > We are talking about two different things here. For KDE SC 4.5 (Qt 4.6) there is no placeHolderText, so the fix should be committed.
> > 
> > What to do when we depend on Qt 4.7 can be decided when KDE SC 4.6 is topic. For example, on mobile platforms, where we don't need the final polish, but are more concerned of code reduction, it could make sense to just use Qt rendering. On desktop platforms, getting consistency with KTextEdit is worth the few hundred bytes the code adds.

Done. Thanks for reviewing. 
For the record, last night I installed Qt4.7, tested the placeholder thing, and made another (much smaller) patch that uses this, and replace the font to italics when needed (so that the visual appearance remains unchanged). I guess I'll come back with it when QT4.7 is out, and kde 4.6 depends on it officially. Unless it is already fixed upstream.

 


- Hugo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4042/#review5824
-----------------------------------------------------------


On 2010-05-20 22:34:59, Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4042/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 22:34:59)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> This patch makes a better job at painting klineEdit 'click' message (e.g. in systemsettings 'search' bar) in a way that is similar to what qlineedit::paintEvent does for normal text. 
> This notably fixes the vertical alignment of the "click" message for some styles, including oxygen (see attached screenshot)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/widgets/klineedit.cpp 1128996 
> 
> Diff: http://reviewboard.kde.org/r/4042/diff
> 
> 
> Testing
> -------
> 
> Tested with oxygen, plastique, skulpture, and bespin. It was checked that the "click message" is vertically positioned the same as normal text (from user input) is, with all styles 
> 
> 
> Screenshots
> -----------
> 
> vertically centered "click" message in systemsettings
>   http://reviewboard.kde.org/r/4042/s/399/
> 
> 
> Thanks,
> 
> Hugo
> 
>