Review Request: KWindowSystemEventFilter: methods for installing global event filters

[Michael Leupold]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/1381/
-----------------------------------------------------------

(Updated 2010-05-21 05:09:24.829070)


Review request for kdelibs.


Changes
-------

Updated the diff to latest trunk.

Does anyone feel qualified to review this or know anyone who is?


Summary
-------

This patch moves the installX11EventFilter functionality from inside KApplication to an external KWindowSystemEventFilter namespace. Like this, non-KApplications can use global event filters (and KApplication gets smaller).

The new methods use QAbstractEventDispatcher and are named KWindowSystemEventFilter::installEventFilter and removeEventFilter. They are not meant to be specific to X11 any longer but the current implementation is only concerned with X11 as I don't have another window system to test it with (I provided stubs that could serve as base for an implementation).


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/kernel/kwindowsystemeventfilter.cpp PRE-CREATION 
  /trunk/KDE/kdelibs/kdeui/kernel/kwindowsystemeventfilter.h PRE-CREATION 
  /trunk/KDE/kdelibs/kdeui/kernel/kapplication.cpp 1129021 
  /trunk/KDE/kdelibs/kdeui/kernel/kapplication.h 1129021 
  /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1129021 

Diff: http://reviewboard.kde.org/r/1381/diff


Testing
-------

Too little I fear. I tested it with KColorDialog which uses KApplication::installX11EventFilter for its color picker and it worked fine.

There should be a unit-test for it but I haven't thought of any.


Thanks,

Michael