Review Request: Use KPluginFactory in KFindDialog to load kregexpeditor dialog

Jean-Baptiste Rouault jbrouault at gmail.com
Thu May 20 19:31:55 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4077/
-----------------------------------------------------------

(Updated 2010-05-20 18:31:55.612777)


Review request for kdelibs and David Faure.


Changes
-------

Removed a line by error...


Summary
-------

In commit 1128695 I ported kregexpeditor to K_PLUGIN_FACTORY.
This patch change the code in KFindDialog so that it can load kregexpeditor dialog again.
I don't know if it's the good way to do it, but KServiceTypeTrader::createInstanceFromQuery()
returns with the error "No service matching the requirements was found"


Diffs (updated)
-----

  /trunk/KDE/kdelibs/kdeui/findreplace/kfinddialog.cpp 1128687 

Diff: http://reviewboard.kde.org/r/4077/diff


Testing
-------

Tested in konqueror by using the search dialog in a <textarea>


Thanks,

Jean-Baptiste





More information about the kde-core-devel mailing list