Review Request: Fix distance between scrollbars and text in kateView

[Dominik Haumann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4058/#review5747
-----------------------------------------------------------

Ship it!


Looks good.

- Dominik


On 2010-05-20 01:09:38, Hugo Pereira Da Costa wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/4058/
> -----------------------------------------------------------
> 
> (Updated 2010-05-20 01:09:38)
> 
> 
> Review request for Kate and kdelibs.
> 
> 
> Summary
> -------
> 
> In Kate View the distance between the text and both scrollbars is larger than in regular views, for some styles, including Oxygen (see first screenshot). This is because normal views use QStyle::PM_ScrollView_ScrollBarSpacing to calculate this distance, whereas KateView uses 2xQStyle::PM_DefaultFrameWidth. 
> 
> This tiny patch fixes this issue (see second screenshot)
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kate/view/kateview.cpp 1127445 
> 
> Diff: http://reviewboard.kde.org/r/4058/diff
> 
> 
> Testing
> -------
> 
> see second screenshot, with oxygen. Also tested with other styles.
> 
> 
> Screenshots
> -----------
> 
> Before fix
>   http://reviewboard.kde.org/r/4058/s/402/
> After fix
>   http://reviewboard.kde.org/r/4058/s/403/
> 
> 
> Thanks,
> 
> Hugo
> 
>