Review Request: Fix distance between scrollbars and text in kateView

Hugo Pereira Da Costa hugo at oxygen-icons.org
Thu May 20 02:09:38 BST 2010


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/4058/
-----------------------------------------------------------

Review request for Kate and kdelibs.


Summary
-------

In Kate View the distance between the text and both scrollbars is larger than in regular views, for some styles, including Oxygen (see first screenshot). This is because normal views use QStyle::PM_ScrollView_ScrollBarSpacing to calculate this distance, whereas KateView uses 2xQStyle::PM_DefaultFrameWidth. 

This tiny patch fixes this issue (see second screenshot)


Diffs
-----

  /trunk/KDE/kdelibs/kate/view/kateview.cpp 1127445 

Diff: http://reviewboard.kde.org/r/4058/diff


Testing
-------

see second screenshot, with oxygen. Also tested with other styles.


Screenshots
-----------

Before fix
  http://reviewboard.kde.org/r/4058/s/402/
After fix
  http://reviewboard.kde.org/r/4058/s/403/


Thanks,

Hugo





More information about the kde-core-devel mailing list