Review Request: kcmshell4 relaxed parameter handling
David Faure
faure at kde.org
Thu May 6 11:58:29 BST 2010
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3829/#review5446
-----------------------------------------------------------
Ship it!
Looks good to me, assuming that locateModule doesn't issue a warning when it can't find a module with that name.
- David
On 2010-04-28 18:59:24, Sascha Peilicke wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3829/
> -----------------------------------------------------------
>
> (Updated 2010-04-28 18:59:24)
>
>
> Review request for kdelibs and Marco Martin.
>
>
> Summary
> -------
>
> This patch makes kcmshell test also for kcm_'name' or kcm'name' if a module of 'name' is not found. Therefore one doesn't need to check if the currently desired module has a prefix or not.
>
>
> Diffs
> -----
>
> trunk/KDE/kdebase/runtime/kcmshell/main.cpp 1119176
>
> Diff: http://reviewboard.kde.org/r/3829/diff
>
>
> Testing
> -------
>
> works on trunk r1119137
>
>
> Thanks,
>
> Sascha
>
>
More information about the kde-core-devel
mailing list