Review Request: kcmshell4 relaxed parameter handling

David Faure faure at kde.org
Thu May 6 11:55:16 BST 2010


On Wednesday 28 April 2010, David Hubner wrote:
> On Wed, 28 Apr 2010 18:59:25 -0000
> 
> "Sascha Peilicke" <sasch.pe at gmx.de> wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://reviewboard.kde.org/r/3829/
> > -----------------------------------------------------------
> > 
> > Review request for kdelibs and Marco Martin.
> > 
> > 
> > Summary
> > -------
> > 
> > This patch makes kcmshell test also for kcm_'name' or kcm'name' if a
> > module of 'name' is not found. Therefore one doesn't need to check if
> > the currently desired module has a prefix or not.
> > 
> > 
> > Diffs
> > -----
> > 
> >   trunk/KDE/kdebase/runtime/kcmshell/main.cpp 1119176
> > 
> > Diff: http://reviewboard.kde.org/r/3829/diff
> > 
> > 
> > Testing
> > -------
> > 
> > works on trunk r1119137
> > 
> > 
> > Thanks,
> > 
> > Sascha
> 
> I would prefer a definate naming policy on KCM's. I would like the KCM,
> desktop file and pot file all be prefixed with KCM_. Would make things
> easier in the long run.

Yes but for all existing modules, we can't rename them, since that would break 
habits and scripts.
Or actually, we could rename then, if the above patch is committed :-)
So in fact this patch makes it possible to, as a second step, define a naming 
policy and rename the modules.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Sponsored by Nokia to work on KDE, incl. Konqueror (http://www.konqueror.org).




More information about the kde-core-devel mailing list