Support for nested groups in kconf_update

Aurélien Gâteau aurelien.gateau at canonical.com
Tue Mar 30 16:36:43 BST 2010


Hi,

It all started with a simple need: I wanted to change the value of a key
with kconf_update... but this key was in a nested group, and
kconf_update does not know about nested groups.

kconf_update is a quite critical tool, but there are no tests for it, so
I started adding tests. I also made it more compliant with kdelibs
coding style. Then I implemented support for nested groups.

I choose not to use reviewboard because I think the consolidated patch
is a bit huge, therefore I attach both the consolidated patch and a
tarball of the 31 patches for review.

The code is still not as nice as it could be, in particular I think the
KonfUpdate class should be moved to its own file so that it can be
unit-tested without forking kconf_update itself. But at least now there
are unit-tests (and support for nested groups).

Can this go in?

Aurélien

-------------- next part --------------
A non-text attachment was scrubbed...
Name: kconf_update-nested-groups.tar.bz2
Type: application/octet-stream
Size: 22233 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100330/3a4bc0f1/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: kconf_update-nested-groups.diff.bz2
Type: application/octet-stream
Size: 12460 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kde-core-devel/attachments/20100330/3a4bc0f1/attachment-0001.obj>


More information about the kde-core-devel mailing list