Review Request: kdesupport/attica krazy fixes

[Glen Kaukola]

> On 2010-03-28 08:58:45, Frederik Gladhorn wrote:
> > /trunk/kdesupport/attica/lib/atticabasejob.h, line 75
> > <http://reviewboard.kde.org/r/3401/diff/1/?file=21655#file21655line75>
> >
> >     Is this binary compatible?

I'm getting mixed opinions on this, so I guess I'll hold off on it.


- Glen


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3401/#review4708
-----------------------------------------------------------


On 2010-03-26 22:48:36, Glen Kaukola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3401/
> -----------------------------------------------------------
> 
> (Updated 2010-03-26 22:48:36)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fixes for the krazy errors in kdesupport/attica
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/attica/lib/atticabasejob.h 1107814 
>   /trunk/kdesupport/attica/lib/content.h 1107814 
>   /trunk/kdesupport/attica/lib/content.cpp 1107814 
>   /trunk/kdesupport/attica/lib/getjob.h 1107814 
>   /trunk/kdesupport/attica/lib/getjob.cpp 1107814 
>   /trunk/kdesupport/attica/lib/knowledgebaseentry.h 1107814 
>   /trunk/kdesupport/attica/lib/metadata.h 1107814 
>   /trunk/kdesupport/attica/lib/postjob.h 1107814 
>   /trunk/kdesupport/attica/lib/postjob.cpp 1107814 
>   /trunk/kdesupport/attica/lib/provider.h 1107814 
>   /trunk/kdesupport/attica/lib/provider.cpp 1107814 
> 
> Diff: http://reviewboard.kde.org/r/3401/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Glen
> 
>