Review Request: kdesupport/attica krazy fixes

[Frederik Gladhorn]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/3401/#review4708
-----------------------------------------------------------


The trivial fixes are good, thanks!
Introducing the d-pointers on the other hand is not binary compatible, so it cannot be done. This should have been done from the start and will be due if we decide to break binary compatibility in a later version.


/trunk/kdesupport/attica/lib/atticabasejob.h
<http://reviewboard.kde.org/r/3401/#comment4200>

    Is this binary compatible?



/trunk/kdesupport/attica/lib/getjob.h
<http://reviewboard.kde.org/r/3401/#comment4201>

    while I would appreciate this change it is not binary compatible for sure. so this would have to wait until we break BC (if ever)



/trunk/kdesupport/attica/lib/postjob.h
<http://reviewboard.kde.org/r/3401/#comment4202>

    BIC


- Frederik


On 2010-03-26 22:48:36, Glen Kaukola wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/3401/
> -----------------------------------------------------------
> 
> (Updated 2010-03-26 22:48:36)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Fixes for the krazy errors in kdesupport/attica
> 
> 
> Diffs
> -----
> 
>   /trunk/kdesupport/attica/lib/atticabasejob.h 1107814 
>   /trunk/kdesupport/attica/lib/content.h 1107814 
>   /trunk/kdesupport/attica/lib/content.cpp 1107814 
>   /trunk/kdesupport/attica/lib/getjob.h 1107814 
>   /trunk/kdesupport/attica/lib/getjob.cpp 1107814 
>   /trunk/kdesupport/attica/lib/knowledgebaseentry.h 1107814 
>   /trunk/kdesupport/attica/lib/metadata.h 1107814 
>   /trunk/kdesupport/attica/lib/postjob.h 1107814 
>   /trunk/kdesupport/attica/lib/postjob.cpp 1107814 
>   /trunk/kdesupport/attica/lib/provider.h 1107814 
>   /trunk/kdesupport/attica/lib/provider.cpp 1107814 
> 
> Diff: http://reviewboard.kde.org/r/3401/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Glen
> 
>