Review Request: Displaying Job Progress in Icons - Review Request

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/2057/#review4323
-----------------------------------------------------------


I still have the concern that the change from JobView to JobViewV2 will break the other GUIs, those that use the "old" JobView. Isn't that the case?
Looking at kdebase, both kuiserver and plasma/generic/dataengines/applicationjobs use org.kde.JobView.

I haven't seen the kdebase part of this patch either, so I don't recall what you changed there (iirc kuiserver will be used even when the job notifications are shown by plasma?); in any case, please test the case where job notifications are enabled and the case where they are disabled (-> separate dialogs are shown). There's a checkbox for this in plasma nowadays.

- David


On 2010-02-27 18:45:10, Shaun Reich wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/2057/
> -----------------------------------------------------------
> 
> (Updated 2010-02-27 18:45:10)
> 
> 
> Review request for kdelibs.
> 
> 
> Summary
> -------
> 
> Hello,
> 
> This merge request is for the changes I have done (on my branch), along with other changes(but those are just waiting for this review).
> 
> The branch was for a project that I have done; displaying the job progress on the file/folder icons. It essentially shows the status, as in whether or not there is a job being performed on a certain dest. url, if there is, a download icon will be shown at the corner, with an animation(circles rotating around a focal point), to show that a transfer is happening (download, copy, etc..). 
> 
> It should be pretty subtle, but may need some tweaking.
> 
> 
> I don't really like the KDirModel::setDisplayJobTransfers(bool), and KFileItemDelegate::setDisplayJobTranfers(bool). They sound terrible imo, and seem to go against Nice API Design, but I use them for lack of a better name. Hopefully you guys have some suggestions?
> 
> Naturally those 2 method properties are off by default, the individual apps should turn it on at their discretion. I will probably do that for Dolphin and the Folderview plasmoid.
> 
> 
> There was some oddity that I experienced, that seemed like an impossibility (then again, lots of bugs do). It wouldn't stop displaying that a job was happening, but I tracked it down and if anything it would have been the sender (kuiserver)'s issue. But I've tested kuiserver quite rigorously...I'm thinking it is just some problem dealing with the *major* version differences I am running.. *shrug*
> 
> 
> I can no longer test this branch with my system, as I run trunk and running this really old checkout side by side...well, that was a pain I am not going to go through again, as apps were crashing so often etc.. and I *still* don't have my plasma's desktop activities back up and running, only 2 system monitors on the desktop :)
> 
> 
> Once it's committed to trunk, I should be able to quickly verify and track down any issues...
> 
> 
> Diffs
> -----
> 
>   /trunk/KDE/kdelibs/kdeui/CMakeLists.txt 1096133 
>   /trunk/KDE/kdelibs/kdeui/jobs/kuiserverjobtracker.cpp 1096133 
> 
> Diff: http://reviewboard.kde.org/r/2057/diff
> 
> 
> Testing
> -------
> 
> oodles.
> 
> 
> Thanks,
> 
> Shaun
> 
>